skylab/MasterPassword
2
0
Fork 0
Code Releases Activity

TestFligt identifier + Localytics crash.

Browse Source 
[IMPROVED]  Use correct device identifier for TestFlight depending on
            whether we're in AdHoc mode or not.
[FIXED]     Crash when sending nil config values to Localytics.
This commit is contained in:
Maarten Billemont 2012-09-21 10:26:53 +02:00
parent 52b8033c37
commit e8c00296bd
2 changed files with 29 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MasterPassword-iOS.xcodeproj/project.pbxproj
View File

@ -5310,7 +5310,7 @@
"\"$(SRCROOT)/External/Pearl/Pearl-Crypto\"", "\"$(SRCROOT)/External/Pearl/Pearl-Crypto\"",
"\"$(SRCROOT)/External/google-plus-ios-sdk/lib\"", "\"$(SRCROOT)/External/google-plus-ios-sdk/lib\"",
); );
"PROVISIONING_PROFILE[sdk=iphoneos*]" = "1D59446F-0568-458A-96A3-B4226BC94A20"; "PROVISIONING_PROFILE[sdk=iphoneos*]" = "E0621374-3E4C-483D-A3F3-46D151712A4F";
SKIP_INSTALL = NO; SKIP_INSTALL = NO;
TARGETED_DEVICE_FAMILY = 1; TARGETED_DEVICE_FAMILY = 1;
}; };

38
MasterPassword/iOS/MPAppDelegate.m
View File

@ -59,8 +59,11 @@
NSString *testFlightToken = [self testFlightToken]; NSString *testFlightToken = [self testFlightToken];
if ([testFlightToken length]) { if ([testFlightToken length]) {
inf(@"Initializing TestFlight"); inf(@"Initializing TestFlight");
#ifdef ADHOC
[TestFlight setDeviceIdentifier:[(id)[UIDevice currentDevice] uniqueIdentifier]]; [TestFlight setDeviceIdentifier:[(id)[UIDevice currentDevice] uniqueIdentifier]];
//[TestFlight setDeviceIdentifier[PearlKeyChain deviceIdentifier]]; #else
[TestFlight setDeviceIdentifier:[PearlKeyChain deviceIdentifier]];
#endif
[TestFlight addCustomEnvironmentInformation:@"Anonymous" forKey:@"username"]; [TestFlight addCustomEnvironmentInformation:@"Anonymous" forKey:@"username"];
[TestFlight addCustomEnvironmentInformation:[PearlKeyChain deviceIdentifier] forKey:@"deviceIdentifier"]; [TestFlight addCustomEnvironmentInformation:[PearlKeyChain deviceIdentifier] forKey:@"deviceIdentifier"];
[TestFlight setOptions:[NSDictionary dictionaryWithObjectsAndKeys: [TestFlight setOptions:[NSDictionary dictionaryWithObjectsAndKeys:
@ -427,27 +430,18 @@
[TestFlight passCheckpoint:MPCheckpointConfig]; [TestFlight passCheckpoint:MPCheckpointConfig];
#endif #endif
[[LocalyticsSession sharedLocalyticsSession] tagEvent:MPCheckpointConfig attributes: [[LocalyticsSession sharedLocalyticsSession] tagEvent:MPCheckpointConfig attributes:@{
@{ @"rememberLogin": [[MPConfig get].rememberLogin boolValue]? @"YES": @"NO",
@"rememberLogin": [[MPConfig get].rememberLogin boolValue] @"iCloud": [[MPConfig get].iCloud boolValue]? @"YES": @"NO",
? @"YES": @"NO", @"iCloudDecided": [[MPConfig get].iCloudDecided boolValue]? @"YES": @"NO",
@"iCloud": [[MPConfig get].iCloud boolValue]? @"YES" @"sendInfo": [[MPiOSConfig get].sendInfo boolValue]? @"YES": @"NO",
: @"NO", @"helpHidden": [[MPiOSConfig get].helpHidden boolValue]? @"YES": @"NO",
@"iCloudDecided": [[MPConfig get].iCloudDecided boolValue] @"showQuickStart": [[MPiOSConfig get].showQuickStart boolValue]? @"YES": @"NO",
? @"YES": @"NO", @"firstRun": [[PearlConfig get].firstRun boolValue]? @"YES": @"NO",
@"sendInfo": [[MPiOSConfig get].sendInfo boolValue] @"launchCount": NilToNSNull([[PearlConfig get].launchCount description]),
? @"YES": @"NO", @"askForReviews": [[PearlConfig get].askForReviews boolValue]? @"YES": @"NO",
@"helpHidden": [[MPiOSConfig get].helpHidden boolValue] @"reviewAfterLaunches": NilToNSNull([[PearlConfig get].reviewAfterLaunches description]),
? @"YES": @"NO", @"reviewedVersion": NilToNSNull([PearlConfig get].reviewedVersion)
@"showQuickStart": [[MPiOSConfig get].showQuickStart boolValue]
? @"YES": @"NO",
@"firstRun": [[PearlConfig get].firstRun boolValue]
? @"YES": @"NO",
@"launchCount": [[PearlConfig get].launchCount description],
@"askForReviews": [[PearlConfig get].askForReviews boolValue]
? @"YES": @"NO",
@"reviewAfterLaunches": [[PearlConfig get].reviewAfterLaunches description],
@"reviewedVersion": [PearlConfig get].reviewedVersion
}]; }];
} }
} }