Ensure GitLab CI does clean builds.

.gitlab-ci.yml

@@ -6,9 +6,10 @@ build_project:
   stage: build
   script:
     - "( brew bundle )"
-    - "( ./lib/bin/build_libsodium-macos )"
+    - "( ./lib/bin/build_libsodium-macos clean && ./lib/bin/build_libsodium-macos )"
+    - "( ./lib/bin/build_libjson-c-macos clean && ./lib/bin/build_libjson-c-macos )"
     - "( cd ./platform-independent/c/cli && ./clean && targets=all ./build && ./mpw-tests && ./mpw-cli-tests )"
-    - "( cd ./gradle && ./gradlew --info clean test )"
+    - "( cd ./gradle && ./gradlew --stacktrace clean test )"
     - "( xcodebuild -workspace platform-darwin/MasterPassword.xcworkspace -configuration 'Test' -scheme 'MasterPassword iOS' -sdk iphonesimulator clean build )"
     - "( xcodebuild -workspace platform-darwin/MasterPassword.xcworkspace -configuration 'Test' -scheme 'MasterPassword macOS' clean build )"
   tags:

gradle/settings.gradle

@@ -1,10 +1,8 @@
 rootProject.name = 'masterpassword'
 
-def local = new Properties();
+def local = new Properties()
-try {
+def localFile = file( 'local.properties' )
-    local.load(file('local.properties').newDataInputStream())
+localFile.exists() && local.load( localFile.newDataInputStream() )
-} catch (FileNotFoundException ignored) {
-}
 
 include 'masterpassword-core'
 project( ':masterpassword-core' ).projectDir = new File( '../platform-independent/c/core' )
@@ -21,9 +19,9 @@ project(':masterpassword-tests').projectDir = new File( '../platform-independent
 include 'masterpassword-gui'
 project( ':masterpassword-gui' ).projectDir = new File( '../platform-independent/java/gui' )
 
-//if (local.containsKey('sdk.dir')) {
+if (local.containsKey( 'sdk.dir' ) && file( local.getProperty( 'sdk.dir' ) ).exists()) {
     include 'masterpassword-android'
     project( ':masterpassword-android' ).projectDir = new File( '../platform-android' )
-//} else {
+} else {
-//    logger.warn( "Skipping masterpassword-android since sdk.dir is not defined in local.properties." )
+    logger.warn( "Skipping masterpassword-android since sdk.dir is not defined in local.properties." )
-//}
+}

lib/bin/build_lib

@@ -187,7 +187,7 @@ _target_build() {
 
     if [[ $platform = windows ]]; then
         # I cannot for the life of me figure out how to pass this command directly into cmd.
-        printf '"%%VSINSTALLDIR%%\Common7\Tools\VsMSBuildCmd.bat" && msbuild /t:Rebuild /p:Configuration=Release;Platform=%s;OutDir=%s' "$arch" "$(cygpath -w "${prefix##$PWD/}/$arch/")" > .build.bat
+        printf '"%%VSINSTALLDIR%%\Common7\Tools\VsMSBuildCmd.bat" && msbuild /t:Rebuild /p:Configuration=ReleaseDLL;Platform=%s;OutDir=%s' "$arch" "$(cygpath -w "${prefix##$PWD/}/$arch/")" > .build.bat
         cmd //c .build.bat
         rm -f .build.bat
     else
@@ -280,6 +280,7 @@ _build() {
             'ios') archs=( 'i386' 'x86_64' 'armv7' 'armv7s' 'arm64' ) ;;
             'android') archs=( 'arm' 'arm64' 'x86' 'x86_64' ) ;;
             'windows') archs=( 'Win32' 'x64' ) ;;
+            *) archs=( 'i386' 'x86_64' ) ;;
         esac
     fi
 
@@ -354,4 +355,3 @@ _build() {
 
     finalize "$prefix" "$platform" "${archs[@]}"
 }
-

platform-independent/c/core/build.gradle

@@ -64,11 +64,11 @@ library {
             }
 
             archive.dependsOn project.tasks.maybeCreate( "build_libsodium-${system}", Exec.class ).configure {
-                commandLine 'bash', "$rootDir/../lib/bin/build_libsodium-${system}"
+                commandLine 'bash', '-x', "$rootDir/../lib/bin/build_libsodium-${system}"
                 privateHeaders.from "$rootDir/../lib/libsodium/src/libsodium/include"
             }
             archive.dependsOn project.tasks.maybeCreate( "build_libjson-c-${system}", Exec.class ).configure {
-                commandLine 'bash', "$rootDir/../lib/bin/build_libjson-c-${system}"
+                commandLine 'bash', '-x', "$rootDir/../lib/bin/build_libjson-c-${system}"
                 privateHeaders.from "$rootDir/../lib/libjson-c/build-${system}~/out"
             }
         }