Fix a crash when the master key could not be computed.

MasterPassword/C/mpw-algorithm.c

@@ -19,6 +19,9 @@
 
 const uint8_t *mpw_masterKeyForUser(const char *fullName, const char *masterPassword, const MPAlgorithmVersion algorithmVersion) {
 
+    if (!fullName || !masterPassword)
+        return NULL;
+
     switch (algorithmVersion) {
         case MPAlgorithmVersion0:
             return mpw_masterKeyForUser_v0( fullName, masterPassword );
@@ -37,6 +40,9 @@ const uint8_t *mpw_masterKeyForUser(const char *fullName, const char *masterPass
 const char *mpw_passwordForSite(const uint8_t *masterKey, const char *siteName, const MPSiteType siteType, const uint32_t siteCounter,
         const MPSiteVariant siteVariant, const char *siteContext, const MPAlgorithmVersion algorithmVersion) {
 
+    if (!masterKey || !siteName)
+        return NULL;
+
     switch (algorithmVersion) {
         case MPAlgorithmVersion0:
             return mpw_passwordForSite_v0( masterKey, siteName, siteType, siteCounter, siteVariant, siteContext );

MasterPassword/ObjC/MPAppDelegate_Key.m

@@ -76,13 +76,14 @@ static NSDictionary *createKeyQuery(MPUserEntity *user, BOOL newItem, MPKeyOrigi
 - (void)storeSavedKeyFor:(MPUserEntity *)user {
 
     if (user.saveKey) {
-        inf( @"Saving key in keychain for user: %@", user.userID );
-
+        NSData *keyData = [self.key keyDataForAlgorithm:user.algorithm];
+        if (keyData) {
             [self forgetSavedKeyFor:user];
+
+            inf( @"Saving key in keychain for user: %@", user.userID );
             [PearlKeyChain addOrUpdateItemForQuery:createKeyQuery( user, YES, nil )
-                                withAttributes:@{
-                                        (__bridge id)kSecValueData : [self.key keyDataForAlgorithm:user.algorithm],
-                                }];
+                                    withAttributes:@{ (__bridge id)kSecValueData : keyData }];
+        }
     }
 }
 

MasterPassword/ObjC/MPKey.m

@@ -62,9 +62,12 @@
 - (NSData *)keyDataForAlgorithm:(id<MPAlgorithm>)algorithm {
 
     NSData *keyData = [_keyCache objectForKey:algorithm];
-    if (!keyData)
-        [_keyCache setObject:keyData = [algorithm keyDataForFullName:self.fullName withMasterPassword:self.masterPassword]
-                      forKey:algorithm];
+    if (keyData)
+        return keyData;
+
+    keyData = [algorithm keyDataForFullName:self.fullName withMasterPassword:self.masterPassword];
+    if (keyData)
+        [_keyCache setObject:keyData forKey:algorithm];
 
     return keyData;
 }