Status bar issue.

[FIXED]     Status bar issue.
[FIXED]     Review dialog link and buttons.

External/Pearl

@@ -1 +1 @@
-Subproject commit 50ec656f29ff83de4f5119cf74935f7c8b2c3e38
+Subproject commit a392ba39e344b6c7da144dcdfb6046235fb24991

MasterPassword/iOS/MPAppDelegate.m

@@ -457,6 +457,11 @@
     [TestFlight passCheckpoint:MPCheckpointShowGuide];
 }
 
+- (void)showFeedback {
+
+    [self showFeedbackWithLogs:YES forVC:nil];
+}
+
 - (void)showFeedbackWithLogs:(BOOL)logs forVC:(UIViewController *)viewController {
 
     if (![PearlEMail canSendMail])

MasterPassword/iOS/MPGuideViewController.m

@@ -28,22 +28,24 @@
 - (void)viewWillAppear:(BOOL)animated {
 
     inf(@"Guide will appear.");
+    [[UIApplication sharedApplication] setStatusBarHidden:YES withAnimation:UIStatusBarAnimationSlide];
+
     [super viewWillAppear:animated];
 }
 
 - (void)viewDidAppear:(BOOL)animated {
 
-    [[UIApplication sharedApplication] setStatusBarHidden:YES withAnimation:animated? UIStatusBarAnimationSlide: UIStatusBarAnimationNone];
-
     [super viewDidAppear:animated];
 }
 
 - (void)viewWillDisappear:(BOOL)animated {
 
     inf(@"Guide will disappear.");
-    [super viewWillDisappear:animated];
+    [[UIApplication sharedApplication] setStatusBarHidden:NO withAnimation:UIStatusBarAnimationSlide];
 
     [MPiOSConfig get].showQuickStart = @NO;
+
+    [super viewWillDisappear:animated];
 }
 
 - (void)viewDidUnload {

MasterPassword/iOS/MPMainViewController.m

@@ -117,14 +117,12 @@
 
 - (void)viewWillAppear:(BOOL)animated {
 
-    inf(@"Main will appear.");
-    [[UIApplication sharedApplication] setStatusBarHidden:NO withAnimation:animated? UIStatusBarAnimationSlide: UIStatusBarAnimationNone];
-
     if ([[MPiOSConfig get].showQuickStart boolValue])
         [[MPAppDelegate get] showGuide];
     if (![MPAppDelegate get].activeUser)
-        [self.navigationController presentViewController:[self.storyboard instantiateViewControllerWithIdentifier:@"MPUnlockViewController"]
+        [self presentViewController:[self.storyboard instantiateViewControllerWithIdentifier:@"MPUnlockViewController"]
-                                                animated:animated completion:nil];
+                           animated:animated completion:nil];
+
 
     if (self.activeElement.user != [MPAppDelegate get].activeUser)
         self.activeElement                      = nil;
@@ -144,10 +142,12 @@
 
 - (void)viewDidAppear:(BOOL)animated {
 
+    inf(@"Main will appear");
+
     // Needed for when we appear after a modal VC dismisses:
     // We can't present until the other modal VC has been fully dismissed and presenting in viewDidAppear will fail.
     if (![MPAppDelegate get].activeUser)
-        [self.navigationController presentViewController:[self.storyboard instantiateViewControllerWithIdentifier:@"MPUnlockViewController"]
+        [self presentViewController:[self.storyboard instantiateViewControllerWithIdentifier:@"MPUnlockViewController"]
                                                 animated:animated completion:nil];
 
     if (![[MPiOSConfig get].actionsTipShown boolValue])

MasterPassword/iOS/MPUnlockViewController.m

@@ -189,6 +189,8 @@
 
 - (void)viewWillAppear:(BOOL)animated {
 
+    [[UIApplication sharedApplication] setStatusBarHidden:YES withAnimation:UIStatusBarAnimationSlide];
+
     inf(@"Lock screen will appear");
     self.selectedUser = nil;
     [self updateUsers];
@@ -198,8 +200,6 @@
 
 - (void)viewDidAppear:(BOOL)animated {
 
-    [[UIApplication sharedApplication] setStatusBarHidden:YES withAnimation:animated? UIStatusBarAnimationSlide: UIStatusBarAnimationNone];
-
     if (!animated)
         [[self findTargetedAvatar] setSelected:YES];
     else
@@ -211,6 +211,8 @@
 - (void)viewWillDisappear:(BOOL)animated {
 
     inf(@"Lock screen will disappear");
+    [[UIApplication sharedApplication] setStatusBarHidden:NO withAnimation:UIStatusBarAnimationSlide];
+
     [super viewWillDisappear:animated];
 }
 

MasterPassword/iOS/MainStoryboard_iPhone.storyboard

@@ -888,7 +888,7 @@ L4m3P4sSw0rD</string>
                         <outlet property="alertBody" destination="jCg-t7-RuK" id="Aru-Nr-DY0"/>
                         <outlet property="alertContainer" destination="yRY-qt-gz8" id="gZx-90-Zgr"/>
                         <outlet property="alertTitle" destination="ZdH-we-KcW" id="VWi-aS-HRw"/>
-                        <outlet property="contentContainer" destination="Juh-jm-UDr" id="ghD-xR-YEY"/>
+                        <outlet property="contentContainer" destination="Juh-jm-UDr" id="MQy-RI-0c6"/>
                         <outlet property="contentField" destination="fiX-10-fif" id="b2c-gv-qMp"/>
                         <outlet property="contentTipBody" destination="ieN-QQ-PyR" id="flJ-gF-wbI"/>
                         <outlet property="contentTipContainer" destination="v2m-Gf-pEV" id="9zL-GR-kyH"/>
@@ -1136,11 +1136,11 @@ Pink fluffy door frame.</string>
             <objects>
                 <viewController storyboardIdentifier="MPUnlockViewController" wantsFullScreenLayout="YES" modalTransitionStyle="flipHorizontal" id="Nbn-Rv-sP1" customClass="MPUnlockViewController" sceneMemberID="viewController">
                     <view key="view" contentMode="scaleToFill" id="PHH-XC-9QQ">
-                        <rect key="frame" x="0.0" y="0.0" width="320" height="480"/>
+                        <rect key="frame" x="0.0" y="20" width="320" height="460"/>
                         <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="top" image="background.png" id="QWe-Gw-rD3">
-                                <rect key="frame" x="0.0" y="0.0" width="320" height="480"/>
+                                <rect key="frame" x="0.0" y="0.0" width="320" height="460"/>
                                 <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                             </imageView>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" image="ui_spinner.png" id="27q-lX-0vy">
@@ -1299,7 +1299,7 @@ Pink fluffy door frame.</string>
                                 <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="calibratedWhite"/>
                             </view>
                             <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" alpha="0.5" contentMode="left" text="Tap and hold to delete or reset." textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="10" id="DBJ-Qi-ZcF">
-                                <rect key="frame" x="20" y="460" width="280" height="20"/>
+                                <rect key="frame" x="20" y="440" width="280" height="20"/>
                                 <autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMinY="YES"/>
                                 <fontDescription key="fontDescription" name="Copperplate" family="Copperplate" pointSize="12"/>
                                 <color key="textColor" white="0.66666666666666663" alpha="1" colorSpace="calibratedWhite"/>
@@ -1307,7 +1307,7 @@ Pink fluffy door frame.</string>
                                 <color key="shadowColor" white="0.0" alpha="1" colorSpace="calibratedWhite"/>
                             </label>
                             <scrollView clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="scaleToFill" showsHorizontalScrollIndicator="NO" showsVerticalScrollIndicator="NO" indicatorStyle="white" delaysContentTouches="NO" id="Blg-F1-9NA">
-                                <rect key="frame" x="0.0" y="10" width="320" height="340"/>
+                                <rect key="frame" x="0.0" y="8" width="320" height="340"/>
                                 <autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMinY="YES" flexibleMaxY="YES"/>
                                 <subviews>
                                     <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="top" showsTouchWhenHighlighted="YES" adjustsImageWhenHighlighted="NO" adjustsImageWhenDisabled="NO" lineBreakMode="middleTruncation" id="Ten-ig-gog">
@@ -1331,7 +1331,7 @@ Pink fluffy door frame.</string>
                                 </connections>
                             </scrollView>
                             <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" alpha="0.0" contentMode="left" text="Maarten Billemont" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" minimumFontSize="10" id="8s0-nT-Aoq">
-                                <rect key="frame" x="90" y="289" width="140" height="15"/>
+                                <rect key="frame" x="90" y="269" width="140" height="15"/>
                                 <autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxX="YES" flexibleMinY="YES"/>
                                 <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="calibratedWhite"/>
                                 <fontDescription key="fontDescription" name="Futura-CondensedExtraBold" family="Futura" pointSize="13"/>
@@ -1339,7 +1339,7 @@ Pink fluffy door frame.</string>
                                 <nil key="highlightedColor"/>
                             </label>
                             <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" text="Maarten Billemont" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" minimumFontSize="10" id="0NM-NI-7UR">
-                                <rect key="frame" x="90" y="86.5" width="140" height="15"/>
+                                <rect key="frame" x="90" y="66" width="140" height="15"/>
                                 <autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxX="YES" flexibleMinY="YES"/>
                                 <color key="backgroundColor" white="0.0" alpha="1" colorSpace="calibratedWhite"/>
                                 <fontDescription key="fontDescription" name="Futura-CondensedExtraBold" family="Futura" pointSize="13"/>
@@ -1417,7 +1417,7 @@ You could use the word wall for  inspiration in finding a memorable master passw
                                 <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="calibratedWhite"/>
                             </view>
                             <activityIndicatorView opaque="NO" contentMode="scaleToFill" hidesWhenStopped="YES" animating="YES" style="whiteLarge" id="XuP-pi-ygN">
-                                <rect key="frame" x="142" y="415" width="37" height="37"/>
+                                <rect key="frame" x="142" y="396" width="37" height="37"/>
                                 <autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxX="YES" flexibleMinY="YES" flexibleMaxY="YES"/>
                             </activityIndicatorView>
                             <button opaque="NO" alpha="0.20000000000000015" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" id="5Qz-dA-cgl" userLabel="facebook">
@@ -1498,7 +1498,6 @@ You could use the word wall for  inspiration in finding a memorable master passw
                         </subviews>
                         <color key="backgroundColor" white="1" alpha="1" colorSpace="custom" customColorSpace="calibratedWhite"/>
                     </view>
-                    <nil key="simulatedStatusBarMetrics"/>
                     <connections>
                         <outlet property="avatarTemplate" destination="Ten-ig-gog" id="0ZZ-z5-d5m"/>
                         <outlet property="avatarsView" destination="Blg-F1-9NA" id="2NL-jU-IMI"/>