Improve notification registration and cleanup + fix removal of site questions.

External/Pearl

@@ -1 +1 @@
-Subproject commit fb7562df9c3a59e8ac21e492b8eac0abcf5aa46e
+Subproject commit c4620deda26475ae4320d9af5b2df4ff96c9093e

MasterPassword/ObjC/MPAppDelegate_Store.m

@@ -192,22 +192,19 @@ PearlAssociatedObjectProperty( NSManagedObjectContext*, MainManagedObjectContext
                         }];
 
 #if TARGET_OS_IPHONE
-        [[NSNotificationCenter defaultCenter] addObserverForName:UIApplicationWillTerminateNotification object:UIApp
+        PearlAddNotificationObserver( UIApplicationWillTerminateNotification, UIApp, [NSOperationQueue mainQueue],
-                                                           queue:[NSOperationQueue mainQueue] usingBlock:
+                ^(MPAppDelegate_Shared *self, NSNotification *note) {
-                        ^(NSNotification *note) {
                     [self.mainManagedObjectContext saveToStore];
-                        }];
+                } );
-        [[NSNotificationCenter defaultCenter] addObserverForName:UIApplicationDidEnterBackgroundNotification object:UIApp
+        PearlAddNotificationObserver( UIApplicationDidEnterBackgroundNotification, UIApp, [NSOperationQueue mainQueue],
-                                                           queue:[NSOperationQueue mainQueue] usingBlock:
+                ^(MPAppDelegate_Shared *self, NSNotification *note) {
-                        ^(NSNotification *note) {
                     [self.mainManagedObjectContext saveToStore];
-                        }];
+                } );
 #else
-    [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationWillTerminateNotification object:NSApp
+        PearlAddNotificationObserver( NSApplicationWillTerminateNotification, NSApp, [NSOperationQueue mainQueue],
-                                                       queue:[NSOperationQueue mainQueue] usingBlock:
+                ^(MPAppDelegate_Shared *self, NSNotification *note) {
-                    ^(NSNotification *note) {
                     [self.mainManagedObjectContext saveToStore];
-                    }];
+                } );
 #endif
 
         // Perform a data sanity check on the newly loaded store to find and fix any issues.

MasterPassword/ObjC/MPStoredSiteEntity.h

@@ -13,6 +13,6 @@
 
 @interface MPStoredSiteEntity : MPSiteEntity
 
-@property (nonatomic, retain) id contentObject;
+@property (nonatomic, retain) NSData *contentObject;
 
 @end

MasterPassword/ObjC/iOS/MPAnswersViewController.m

@@ -14,6 +14,7 @@
 #import "MPPasswordsViewController.h"
 #import "MPCoachmarkViewController.h"
 #import "MPSiteQuestionEntity.h"
+#import "MPOverlayViewController.h"
 
 @interface MPAnswersViewController()
 
@@ -35,6 +36,25 @@
     self.view.backgroundColor = [UIColor clearColor];
 }
 
+- (void)viewWillAppear:(BOOL)animated {
+
+    [super viewWillAppear:animated];
+
+    PearlAddNotificationObserver( MPSignedOutNotification, nil, [NSOperationQueue mainQueue], ^(NSNotification *note) {
+        if (![note.userInfo[@"animated"] boolValue])
+            [UIView setAnimationsEnabled:NO];
+        [[MPOverlaySegue dismissViewController:self] perform];
+        [UIView setAnimationsEnabled:YES];
+    } );
+}
+
+- (void)viewWillDisappear:(BOOL)animated {
+
+    [super viewWillDisappear:animated];
+
+    PearlRemoveNotificationObservers();
+}
+
 - (UIStatusBarStyle)preferredStatusBarStyle {
 
     return UIStatusBarStyleLightContent;
@@ -147,7 +167,10 @@
 
                                  [MPiOSAppDelegate managedObjectContextPerformBlock:^(NSManagedObjectContext *context) {
                                      MPSiteEntity *site_ = [self siteInContext:context];
-                                     [site_ removeQuestions:site_.questions];
+                                     NSOrderedSet *questions = [site_.questions copy];
+                                     for (MPSiteQuestionEntity *question in questions)
+                                         [context deleteObject:question];
+                                     [site_ removeQuestions:questions];
                                      [context saveToStore];
                                      [self setMultiple:NO animated:YES];
                                  }];

MasterPassword/ObjC/iOS/MPCombinedViewController.m

@@ -22,9 +22,7 @@
 #import "MPEmergencyViewController.h"
 #import "MPPasswordsSegue.h"
 
-@implementation MPCombinedViewController {
+@implementation MPCombinedViewController
-    NSArray *_notificationObservers;
-}
 
 #pragma mark - Life
 
@@ -47,14 +45,22 @@
 
     [super viewDidAppear:animated];
 
-    [self registerObservers];
+    Weakify( self );
+    PearlAddNotificationObserver( MPSignedInNotification, nil, [NSOperationQueue mainQueue], ^(NSNotification *note) {
+        Strongify( self );
+        [self setMode:MPCombinedModePasswordSelection];
+    } );
+    PearlAddNotificationObserver( MPSignedOutNotification, nil, [NSOperationQueue mainQueue], ^(NSNotification *note) {
+        Strongify( self );
+        [self setMode:MPCombinedModeUserSelection animated:[note.userInfo[@"animated"] boolValue]];
+    } );
 }
 
 - (void)viewWillDisappear:(BOOL)animated {
 
     [super viewWillDisappear:animated];
 
-    [self removeObservers];
+    PearlRemoveNotificationObservers();
 }
 
 - (void)prepareForSegue:(UIStoryboardSegue *)segue sender:(id)sender {
@@ -142,35 +148,4 @@
 
 #pragma mark - Private
 
-- (void)registerObservers {
-
-    if ([_notificationObservers count])
-        return;
-
-    Weakify( self );
-    _notificationObservers = @[
-            [[NSNotificationCenter defaultCenter]
-                    addObserverForName:MPSignedInNotification object:nil
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
-                        [self setMode:MPCombinedModePasswordSelection];
-                    }],
-            [[NSNotificationCenter defaultCenter]
-                    addObserverForName:MPSignedOutNotification object:nil
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
-                        [self setMode:MPCombinedModeUserSelection animated:[note.userInfo[@"animated"] boolValue]];
-                    }],
-    ];
-}
-
-- (void)removeObservers {
-
-    for (id observer in _notificationObservers)
-        [[NSNotificationCenter defaultCenter] removeObserver:observer];
-    _notificationObservers = nil;
-}
-
 @end

MasterPassword/ObjC/iOS/MPEmergencyViewController.m

@@ -23,7 +23,6 @@
     MPKey *_key;
     NSOperationQueue *_emergencyKeyQueue;
     NSOperationQueue *_emergencyPasswordQueue;
-    NSArray *_notificationObservers;
 }
 
 - (void)viewDidLoad {
@@ -42,14 +41,17 @@
     [super viewWillAppear:animated];
 
     [self reset];
-    [self registerObservers];
+    PearlAddNotificationObserver( UIApplicationWillResignActiveNotification, nil, [NSOperationQueue mainQueue],
+            ^(MPEmergencyViewController *self, NSNotification *note) {
+                [self performSegueWithIdentifier:@"unwind-popover" sender:self];
+            } );
 }
 
 - (void)viewDidDisappear:(BOOL)animated {
 
     [super viewDidDisappear:animated];
 
-    [self removeObservers];
+    PearlRemoveNotificationObservers();
     [self reset];
 }
 
@@ -168,28 +170,4 @@
     [self updateKey];
 }
 
-- (void)registerObservers {
-
-    if ([_notificationObservers count])
-        return;
-
-    Weakify(self);
-    _notificationObservers = @[
-            [[NSNotificationCenter defaultCenter]
-                    addObserverForName:UIApplicationWillResignActiveNotification object:nil
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                Strongify(self);
-
-                [self performSegueWithIdentifier:@"unwind-popover" sender:self];
-            }],
-    ];
-}
-
-- (void)removeObservers {
-
-    for (id observer in _notificationObservers)
-        [[NSNotificationCenter defaultCenter] removeObserver:observer];
-    _notificationObservers = nil;
-}
-
 @end

MasterPassword/ObjC/iOS/MPLogsViewController.m

@@ -27,18 +27,17 @@
     [super viewDidLoad];
 
     self.view.backgroundColor = [UIColor clearColor];
-
-    [[NSNotificationCenter defaultCenter] addObserverForName:NSUserDefaultsDidChangeNotification object:nil
-                                                       queue:[NSOperationQueue mainQueue] usingBlock:
-            ^(NSNotification *note) {
-                self.levelControl.selectedSegmentIndex = [[MPiOSConfig get].traceMode boolValue]? 1: 0;
-            }];
 }
 
 - (void)viewWillAppear:(BOOL)animated {
 
     [super viewWillAppear:animated];
 
+    PearlAddNotificationObserver( NSUserDefaultsDidChangeNotification, nil, [NSOperationQueue mainQueue],
+            ^(MPLogsViewController *self, NSNotification *note) {
+                self.levelControl.selectedSegmentIndex = [[MPiOSConfig get].traceMode boolValue]? 1: 0;
+            } );
+
     self.logView.contentInset = UIEdgeInsetsMake( 64, 0, 93, 0 );
 
     [self refresh:nil];
@@ -46,6 +45,13 @@
     self.levelControl.selectedSegmentIndex = [[MPiOSConfig get].traceMode boolValue]? 1: 0;
 }
 
+- (void)viewWillDisappear:(BOOL)animated {
+
+    [super viewWillDisappear:animated];
+
+    PearlRemoveNotificationObservers();
+}
+
 - (IBAction)toggleLevelControl:(UISegmentedControl *)sender {
 
     BOOL traceEnabled = (BOOL)self.levelControl.selectedSegmentIndex;

MasterPassword/ObjC/iOS/MPOverlayViewController.h

@@ -23,4 +23,7 @@
 @end
 
 @interface MPOverlaySegue : UIStoryboardSegue
+
++ (instancetype)dismissViewController:(UIViewController *)viewController;
+
 @end

MasterPassword/ObjC/iOS/MPOverlayViewController.m

@@ -52,17 +52,20 @@
     return [[MPOverlaySegue alloc] initWithIdentifier:identifier source:fromViewController destination:toViewController];
 }
 
-- (void)addDismissButtonForSegue:(MPOverlaySegue *)segue {
+- (UIView *)addDismissButtonForSegue:(MPOverlaySegue *)segue {
 
     UIButton *dismissButton = [UIButton buttonWithType:UIButtonTypeCustom];
     [dismissButton addTarget:self action:@selector( dismissOverlay: ) forControlEvents:UIControlEventTouchUpInside];
-    dismissButton.backgroundColor = [UIColor colorWithWhite:0 alpha:0.3f];
+    dismissButton.backgroundColor = [UIColor colorWithWhite:0 alpha:0.5f];
+    dismissButton.alpha = 0;
     dismissButton.frame = self.view.bounds;
     dismissButton.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
     _dismissSegueByButton[[NSValue valueWithNonretainedObject:dismissButton]] =
             [[MPOverlaySegue alloc] initWithIdentifier:@"dismiss-overlay"
                                                 source:segue.destinationViewController destination:segue.sourceViewController];
+
     [self.view addSubview:dismissButton];
+    return dismissButton;
 }
 
 - (void)dismissOverlay:(UIButton *)dismissButton {
@@ -96,6 +99,11 @@
 
 @implementation MPOverlaySegue
 
++ (instancetype)dismissViewController:(UIViewController *)viewController {
+
+    return [[self alloc] initWithIdentifier:nil source:viewController destination:viewController];
+}
+
 - (void)perform {
 
     UIViewController *sourceViewController = self.sourceViewController;
@@ -109,6 +117,7 @@
     if (!destinationViewController.parentViewController) {
         // Winding
         [containerViewController addChildViewController:destinationViewController];
+        UIView *dismissButton = [containerViewController addDismissButtonForSegue:self];
 
         destinationViewController.view.frame = containerViewController.view.bounds;
         destinationViewController.view.translatesAutoresizingMaskIntoConstraints = YES;
@@ -125,6 +134,7 @@
                     destinationViewController.view.transform = CGAffineTransformIdentity;
                     CGRectSetY( destinationViewController.view.frame, 0 );
                     destinationViewController.view.alpha = 1;
+                    dismissButton.alpha = 1;
                 }       completion:^(BOOL finished) {
                     [destinationViewController didMoveToParentViewController:containerViewController];
                     [containerViewController setNeedsStatusBarAppearanceUpdate];

MasterPassword/ObjC/iOS/MPPasswordsViewController.m

@@ -22,7 +22,6 @@
 #import "MPPopdownSegue.h"
 #import "MPAppDelegate_Key.h"
 #import "MPPasswordCell.h"
-#import "UICollectionView+PearlReloadFromArray.h"
 #import "MPAnswersViewController.h"
 
 @interface MPPasswordsViewController()<NSFetchedResultsControllerDelegate>
@@ -33,10 +32,6 @@
 @end
 
 @implementation MPPasswordsViewController {
-    __weak id _storeChangingObserver;
-    __weak id _storeChangedObserver;
-    __weak id _mocObserver;
-    NSArray *_notificationObservers;
     __weak UITapGestureRecognizer *_passwordsDismissRecognizer;
     NSFetchedResultsController *_fetchedResultsController;
     UIColor *_backgroundColor;
@@ -69,7 +64,6 @@
     [super viewWillAppear:animated];
 
     [self registerObservers];
-    [self observeStore];
     [self updateConfigKey:nil];
     [self updatePasswords];
 }
@@ -90,8 +84,7 @@
 
     [super viewWillDisappear:animated];
 
-    [self removeObservers];
+    PearlRemoveNotificationObservers();
-    [self stopObservingStore];
 }
 
 - (void)prepareForSegue:(UIStoryboardSegue *)segue sender:(id)sender {
@@ -280,97 +273,49 @@ referenceSizeForHeaderInSection:(NSInteger)section {
 
 - (void)registerObservers {
 
-    if ([_notificationObservers count])
+    PearlRemoveNotificationObservers();
-        return;
+    PearlAddNotificationObserver( UIApplicationDidEnterBackgroundNotification, nil, [NSOperationQueue mainQueue],
-
+            ^(MPPasswordsViewController *self, NSNotification *note) {
-    Weakify( self );
-    _notificationObservers = @[
-            [[NSNotificationCenter defaultCenter]
-                    addObserverForName:UIApplicationDidEnterBackgroundNotification object:nil
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
                 self.passwordSelectionContainer.alpha = 0;
-                    }],
+            } );
-            [[NSNotificationCenter defaultCenter]
+    PearlAddNotificationObserver( UIApplicationWillEnterForegroundNotification, nil, [NSOperationQueue mainQueue],
-                    addObserverForName:UIApplicationWillEnterForegroundNotification object:nil
+            ^(MPPasswordsViewController *self, NSNotification *note) {
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
                 [self updatePasswords];
-                    }],
+            } );
-            [[NSNotificationCenter defaultCenter]
+    PearlAddNotificationObserver( UIApplicationDidBecomeActiveNotification, nil, [NSOperationQueue mainQueue],
-                    addObserverForName:UIApplicationDidBecomeActiveNotification object:nil
+            ^(MPPasswordsViewController *self, NSNotification *note) {
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
                 [UIView animateWithDuration:0.7f animations:^{
                     self.passwordSelectionContainer.alpha = 1;
                 }];
-                    }],
+            } );
-            [[NSNotificationCenter defaultCenter]
+    PearlAddNotificationObserver( MPSignedOutNotification, nil, [NSOperationQueue mainQueue],
-                    addObserverForName:MPSignedOutNotification object:nil
+            ^(MPPasswordsViewController *self, NSNotification *note) {
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
                 _fetchedResultsController = nil;
                 self.passwordsSearchBar.text = nil;
                 [self.passwordCollectionView reloadData];
-                    }],
+            } );
-            [[NSNotificationCenter defaultCenter]
+    PearlAddNotificationObserver( MPCheckConfigNotification, nil, [NSOperationQueue mainQueue],
-                    addObserverForName:MPCheckConfigNotification object:nil
+            ^(MPPasswordsViewController *self, NSNotification *note) {
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
                 [self updateConfigKey:note.object];
-                    }],
+            } );
-    ];
+    PearlAddNotificationObserver( NSPersistentStoreCoordinatorStoresWillChangeNotification, nil, nil,
-}
+            ^(MPPasswordsViewController *self, NSNotification *note) {
-
+                self->_fetchedResultsController = nil;
-- (void)removeObservers {
+                [self.passwordCollectionView reloadData];
-
+            } );
-    for (id observer in _notificationObservers)
+    PearlAddNotificationObserver( NSPersistentStoreCoordinatorStoresDidChangeNotification, nil, nil,
-        [[NSNotificationCenter defaultCenter] removeObserver:observer];
+            ^(MPPasswordsViewController *self, NSNotification *note) {
-    _notificationObservers = nil;
+                [self updatePasswords];
-}
+                [self registerObservers];
-
+            } );
-- (void)observeStore {
-
-    Weakify( self );
 
     NSManagedObjectContext *mainContext = [MPiOSAppDelegate managedObjectContextForMainThreadIfReady];
-    if (!_mocObserver && mainContext)
+    if (mainContext)
-        _mocObserver = [[NSNotificationCenter defaultCenter]
+        PearlAddNotificationObserver( NSManagedObjectContextDidSaveNotification, mainContext, nil,
-                addObserverForName:NSManagedObjectContextDidSaveNotification object:mainContext
+                ^(MPPasswordsViewController *self, NSNotification *note) {
-                             queue:nil usingBlock:^(NSNotification *note) {
+                    if (![[MPiOSAppDelegate get] activeUserInContext:note.object])
-                    if (![[MPiOSAppDelegate get] activeUserInContext:mainContext])
                         [[MPiOSAppDelegate get] signOutAnimated:YES];
-                }];
+                } );
-    if (!_storeChangingObserver)
-        _storeChangingObserver = [[NSNotificationCenter defaultCenter]
-                addObserverForName:NSPersistentStoreCoordinatorStoresWillChangeNotification object:nil
-                             queue:nil usingBlock:^(NSNotification *note) {
-                    Strongify( self );
-                    self->_fetchedResultsController = nil;
-                    if (self->_mocObserver)
-                        [[NSNotificationCenter defaultCenter] removeObserver:self->_mocObserver];
-                    [self.passwordCollectionView reloadData];
-                }];
-    if (!_storeChangedObserver)
-        _storeChangedObserver = [[NSNotificationCenter defaultCenter]
-                addObserverForName:NSPersistentStoreCoordinatorStoresDidChangeNotification object:nil
-                             queue:nil usingBlock:^(NSNotification *note) {
-                    Strongify( self );
-                    [self updatePasswords];
-                }];
-}
-
-- (void)stopObservingStore {
-
-    if (_mocObserver)
-        [[NSNotificationCenter defaultCenter] removeObserver:_mocObserver];
-    if (_storeChangingObserver)
-        [[NSNotificationCenter defaultCenter] removeObserver:_storeChangingObserver];
-    if (_storeChangedObserver)
-        [[NSNotificationCenter defaultCenter] removeObserver:_storeChangedObserver];
 }
 
 - (void)updateConfigKey:(NSString *)key {
@@ -454,7 +399,7 @@ referenceSizeForHeaderInSection:(NSInteger)section {
                     initWithFetchRequest:fetchRequest managedObjectContext:mainContext sectionNameKeyPath:nil cacheName:nil];
             _fetchedResultsController.delegate = self;
         }];
-        [self observeStore];
+        [self registerObservers];
     }
 
     return _fetchedResultsController;

MasterPassword/ObjC/iOS/MPStoreViewController.m

@@ -50,15 +50,22 @@ PearlEnum( MPDevelopmentFuelConsumption,
         }
     }];
 
-    [[NSNotificationCenter defaultCenter] addObserverForName:NSUserDefaultsDidChangeNotification object:nil
+    PearlAddNotificationObserver( NSUserDefaultsDidChangeNotification, nil, [NSOperationQueue mainQueue],
-                                                       queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
+            ^(MPStoreViewController *self, NSNotification *note) {
                 [self updateProducts];
                 [self updateFuel];
-            }];
+            } );
     [[MPiOSAppDelegate get] registerProductsObserver:self];
     [self updateFuel];
 }
 
+- (void)viewWillDisappear:(BOOL)animated {
+
+    [super viewWillDisappear:animated];
+
+    PearlRemoveNotificationObservers();
+}
+
 #pragma mark - UITableViewDelegate
 
 - (MPStoreProductCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {

MasterPassword/ObjC/iOS/MPUsersViewController.m

@@ -22,9 +22,7 @@
 #import "MPiOSAppDelegate.h"
 #import "MPAppDelegate_Store.h"
 #import "MPAppDelegate_Key.h"
-#import "PearlSizedTextView.h"
 #import "MPWebViewController.h"
-#import "UIView+FontScale.h"
 
 typedef NS_ENUM( NSUInteger, MPActiveUserState ) {
     /** The users are all inactive */
@@ -51,10 +49,6 @@ typedef NS_ENUM( NSUInteger, MPActiveUserState ) {
 @end
 
 @implementation MPUsersViewController {
-    __weak id _storeChangingObserver;
-    __weak id _storeChangedObserver;
-    __weak id _mocObserver;
-    NSArray *_notificationObservers;
     NSString *_masterPasswordChoice;
     NSOperationQueue *_afterUpdates;
 }
@@ -89,8 +83,7 @@ typedef NS_ENUM( NSUInteger, MPActiveUserState ) {
 
     [super viewWillDisappear:animated];
 
-    [self removeObservers];
+    PearlRemoveNotificationObservers();
-    [self stopObservingStore];
 
     [self.marqueeTipTimer invalidate];
 }
@@ -99,7 +92,6 @@ typedef NS_ENUM( NSUInteger, MPActiveUserState ) {
 
     [super viewDidAppear:animated];
 
-    [self observeStore];
     [self registerObservers];
     [self reloadUsers];
 
@@ -475,15 +467,15 @@ referenceSizeForFooterInSection:(NSInteger)section {
     if ([nextMarqueeString isEqualToString:[self.marqueeButton titleForState:UIControlStateNormal]])
         return;
 
-    [UIView animateWithDuration:timer? 0.5: 0 animations:^{
+    [UIView animateWithDuration:timer? 0.5f: 0 animations:^{
         self.marqueeButton.alpha = 0;
     }                completion:^(BOOL finished) {
         if (!finished)
             return;
 
         [self.marqueeButton setTitle:nextMarqueeString forState:UIControlStateNormal];
-        [UIView animateWithDuration:timer? 0.5: 0 animations:^{
+        [UIView animateWithDuration:timer? 0.5f: 0 animations:^{
-            self.marqueeButton.alpha = 0.5;
+            self.marqueeButton.alpha = 0.5f;
         }];
     }];
 }
@@ -586,54 +578,27 @@ referenceSizeForFooterInSection:(NSInteger)section {
 
 - (void)registerObservers {
 
-    if ([_notificationObservers count])
+    [self removeKeyPathObservers];
-        return;
-
-    Weakify( self );
-    _notificationObservers = @[
-            [[NSNotificationCenter defaultCenter]
-                    addObserverForName:UIApplicationDidEnterBackgroundNotification object:nil
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
-                        self.userSelectionContainer.alpha = 0;
-                    }],
-            [[NSNotificationCenter defaultCenter]
-                    addObserverForName:UIApplicationWillEnterForegroundNotification object:nil
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
-                        [self reloadUsers];
-                    }],
-            [[NSNotificationCenter defaultCenter]
-                    addObserverForName:UIApplicationDidBecomeActiveNotification object:nil
-                                 queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *note) {
-                        Strongify( self );
-
-                        [UIView animateWithDuration:0.7f animations:^{
-                            self.userSelectionContainer.alpha = 1;
-                        }];
-                    }],
-    ];
-
     [self observeKeyPath:@"avatarCollectionView.contentOffset" withBlock:
             ^(id from, id to, NSKeyValueChange cause, MPUsersViewController *_self) {
                 [_self updateAvatarVisibility];
             }];
-}
 
-- (void)removeObservers {
+    PearlRemoveNotificationObservers();
-
+    PearlAddNotificationObserver( UIApplicationDidEnterBackgroundNotification, nil, [NSOperationQueue mainQueue],
-    for (id observer in _notificationObservers)
+            ^(MPUsersViewController *self, NSNotification *note) {
-        [[NSNotificationCenter defaultCenter] removeObserver:observer];
+                self.userSelectionContainer.alpha = 0;
-    _notificationObservers = nil;
+            } );
-
+    PearlAddNotificationObserver( UIApplicationWillEnterForegroundNotification, nil, [NSOperationQueue mainQueue],
-    [self removeKeyPathObservers];
+            ^(MPUsersViewController *self, NSNotification *note) {
-}
+                [self reloadUsers];
-
+            } );
-- (void)observeStore {
+    PearlAddNotificationObserver( UIApplicationDidBecomeActiveNotification, nil, [NSOperationQueue mainQueue],
-
+            ^(MPUsersViewController *self, NSNotification *note) {
-    Weakify( self );
+                [UIView animateWithDuration:0.5f animations:^{
+                    self.userSelectionContainer.alpha = 1;
+                }];
+            } );
 
     NSManagedObjectContext *mainContext = [MPiOSAppDelegate managedObjectContextForMainThreadIfReady];
     [UIView animateWithDuration:0.3f animations:^{
@@ -644,11 +609,9 @@ referenceSizeForFooterInSection:(NSInteger)section {
     if (!mainContext && !self.storeLoadingActivity.isAnimating)
         [self.storeLoadingActivity startAnimating];
 
-    if (!_mocObserver && mainContext)
+    if (mainContext)
-        _mocObserver = [[NSNotificationCenter defaultCenter]
+    PearlAddNotificationObserver( NSManagedObjectContextObjectsDidChangeNotification, mainContext, [NSOperationQueue mainQueue],
-                addObserverForName:NSManagedObjectContextObjectsDidChangeNotification object:mainContext
+            ^(MPUsersViewController *self, NSNotification *note) {
-                             queue:nil usingBlock:^(NSNotification *note) {
-                    Strongify( self );
                 NSSet *insertedObjects = note.userInfo[NSInsertedObjectsKey];
                 NSSet *deletedObjects = note.userInfo[NSDeletedObjectsKey];
                 if ([[NSSetUnion( insertedObjects, deletedObjects )
@@ -656,39 +619,21 @@ referenceSizeForFooterInSection:(NSInteger)section {
                             return [evaluatedObject isKindOfClass:[MPUserEntity class]];
                         }]] count])
                     [self reloadUsers];
-                }];
+            } );
-    if (!_storeChangingObserver)
+    PearlAddNotificationObserver( NSPersistentStoreCoordinatorStoresWillChangeNotification, nil, [NSOperationQueue mainQueue],
-        _storeChangingObserver = [[NSNotificationCenter defaultCenter]
+            ^(MPUsersViewController *self, NSNotification *note) {
-                addObserverForName:NSPersistentStoreCoordinatorStoresWillChangeNotification object:nil
-                             queue:nil usingBlock:^(NSNotification *note) {
-                    Strongify( self );
-                    if (self->_mocObserver)
-                        [[NSNotificationCenter defaultCenter] removeObserver:self->_mocObserver];
                 self.userIDs = nil;
-                }];
+            } );
-    if (!_storeChangedObserver)
+    PearlAddNotificationObserver( NSPersistentStoreCoordinatorStoresDidChangeNotification, nil, [NSOperationQueue mainQueue],
-        _storeChangedObserver = [[NSNotificationCenter defaultCenter]
+            ^(MPUsersViewController *self, NSNotification *note) {
-                addObserverForName:NSPersistentStoreCoordinatorStoresDidChangeNotification object:nil
+                [self registerObservers];
-                             queue:nil usingBlock:^(NSNotification *note) {
-                    Strongify( self );
                 [self reloadUsers];
-                }];
+            } );
-}
-
-- (void)stopObservingStore {
-
-    if (_mocObserver)
-        [[NSNotificationCenter defaultCenter] removeObserver:_mocObserver];
-    if (_storeChangingObserver)
-        [[NSNotificationCenter defaultCenter] removeObserver:_storeChangingObserver];
-    if (_storeChangedObserver)
-        [[NSNotificationCenter defaultCenter] removeObserver:_storeChangedObserver];
 }
 
 - (void)reloadUsers {
 
     [self afterUpdatesMainQueue:^{
-        [self observeStore];
         if (![MPiOSAppDelegate managedObjectContextForMainThreadPerformBlockAndWait:^(NSManagedObjectContext *mainContext) {
             NSError *error = nil;
             NSFetchRequest *fetchRequest = [NSFetchRequest fetchRequestWithEntityName:NSStringFromClass( [MPUserEntity class] )];

MasterPassword/ObjC/iOS/MPiOSAppDelegate.m

@@ -69,18 +69,15 @@
         err( @"During Analytics Setup: %@", exception );
     }
     @try {
-        [[NSNotificationCenter defaultCenter] addObserverForName:MPCheckConfigNotification object:nil queue:[NSOperationQueue mainQueue]
+        PearlAddNotificationObserver( MPCheckConfigNotification, nil, [NSOperationQueue mainQueue], ^(id self, NSNotification *note) {
-                                                      usingBlock:^(NSNotification *note) {
             [self updateConfigKey:note.object];
-                                                      }];
+        } );
-        [[NSNotificationCenter defaultCenter] addObserverForName:kIASKAppSettingChanged object:nil queue:nil usingBlock:
+        PearlAddNotificationObserver( kIASKAppSettingChanged, nil, nil, ^(id self, NSNotification *note) {
-                ^(NSNotification *note) {
             [[NSNotificationCenter defaultCenter] postNotificationName:MPCheckConfigNotification object:note.object];
-                }];
+        } );
-        [[NSNotificationCenter defaultCenter] addObserverForName:NSUserDefaultsDidChangeNotification object:nil queue:nil usingBlock:
+        PearlAddNotificationObserver( NSUserDefaultsDidChangeNotification, nil, nil, ^(id self, NSNotification *note) {
-                ^(NSNotification *note) {
             [[NSNotificationCenter defaultCenter] postNotificationName:MPCheckConfigNotification object:nil];
-                }];
+        } );
 
 #ifdef ADHOC
         [PearlAlert showAlertWithTitle:@"Welcome, tester!" message:
@@ -106,8 +103,7 @@
     @try {
         inf( @"Started up with device identifier: %@", [PearlKeyChain deviceIdentifier] );
 
-        [[NSNotificationCenter defaultCenter] addObserverForName:MPFoundInconsistenciesNotification object:nil queue:nil usingBlock:
+        PearlAddNotificationObserver( MPFoundInconsistenciesNotification, nil, nil, ^(id self, NSNotification *note) {
-                ^(NSNotification *note) {
             switch ((MPFixableResult)[note.userInfo[MPInconsistenciesFixResultUserKey] unsignedIntegerValue]) {
 
                 case MPFixableResultNoProblems:
@@ -127,7 +123,7 @@
                                  tappedButtonBlock:nil cancelTitle:[PearlStrings get].commonButtonOkay otherTitles:nil];
                     break;
             }
-                }];
+        } );
 
         PearlMainQueue( ^{
             if ([[MPiOSConfig get].showSetup boolValue])

MasterPassword/ObjC/iOS/MasterPassword-iOS.xcodeproj/project.pbxproj

@@ -433,6 +433,7 @@
 		93D39156E806BB78E04F78B9 /* PearlSizedTextView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PearlSizedTextView.m; sourceTree = "<group>"; };
 		93D3916C1D8F1427DFBDEBCA /* MPAppSettingsViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MPAppSettingsViewController.m; sourceTree = "<group>"; };
 		93D391943675426839501BB8 /* MPLogsViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MPLogsViewController.h; sourceTree = "<group>"; };
+		93D391AA32F24290C424438E /* NSNotificationCenter+PearlEasyCleanup.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSNotificationCenter+PearlEasyCleanup.h"; sourceTree = "<group>"; };
 		93D39246FC21C6E63E35D615 /* UICollectionView+PearlReloadFromArray.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UICollectionView+PearlReloadFromArray.h"; sourceTree = "<group>"; };
 		93D3924D6F77E6BF41AC32D3 /* MPRootSegue.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MPRootSegue.h; sourceTree = "<group>"; };
 		93D3924EE15017F8A12CB436 /* MPPasswordsViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MPPasswordsViewController.m; sourceTree = "<group>"; };
@@ -2632,6 +2633,7 @@
 				DAFE45F915039823003ABA7C /* Resources */,
 				93D39F9106F2CCFB94283188 /* NSError+PearlFullDescription.m */,
 				93D398C95847261903D781D3 /* NSError+PearlFullDescription.h */,
+				93D391AA32F24290C424438E /* NSNotificationCenter+PearlEasyCleanup.h */,
 			);
 			path = Pearl;
 			sourceTree = "<group>";