Fix linting errors

Remove unused imports
Disable redundant errors
Add notes for why errors are disabled

.github/workflows/ci.yaml

@@ -12,6 +12,8 @@ jobs:
     strategy:
       matrix:
         python:
+          - version: "3.7"
+            toxenv: py37
           - version: "3.8"
             toxenv: py38
           - version: "3.9"
@@ -20,8 +22,6 @@ jobs:
             toxenv: py310
           - version: "3.11"
             toxenv: py311
-          - version: "3.12"
-            toxenv: py312
       fail-fast: true
     steps:
       - name: Checkout

.pre-commit-config.yaml

@@ -47,13 +47,12 @@ repos:
 
       - id: reorder-python-imports
         name: reorder-python-imports
-        entry: isort
+        entry: reorder-python-imports
         language: system
-        require_serial: true
+        args:
+          - "--unclassifiable-application-module=tox_poetry_installer"
         types:
           - python
-        args:
-          - "--filter-files"
 
       - id: black
         name: black

pyproject.toml

@@ -23,11 +23,11 @@ classifiers = [
   "Natural Language :: English",
   "Operating System :: OS Independent",
   "Programming Language :: Python :: 3",
+  "Programming Language :: Python :: 3.7",
   "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
-  "Programming Language :: Python :: 3.12",
   "Programming Language :: Python :: Implementation :: CPython",
 ]
 
@@ -35,34 +35,30 @@ classifiers = [
 poetry_installer = "tox_poetry_installer"
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.7"
 cleo = ">=1.0,<3.0"
 poetry = "^1.5.0"
 poetry-core = "^1.1.0"
-tox = "^4.1"
+tox = "^4"
 
 [tool.poetry.group.dev.dependencies]
-bandit = {version = "^1.7.7", python = "^3.10"}
-black = {version = "^24.3.0", python = "^3.10"}
-blacken-docs = {version = "^1.18.0", python = "^3.10"}
-ipython = {version = "^8.10.1", python = "^3.10"}
-isort = {version = "^5.13.2", python = "^3.10"}
-mdformat = {version = "^0.7", python = "^3.10"}
-mdformat-gfm = {version = "^0.3", python = "^3.10"}
-mypy = {version = "^0.930", python = "^3.10"}
-pre-commit = {version = "^3.8.0", python = "^3.10"}
-pre-commit-hooks = {version = "^4.6.0", python = "^3.10"}
-pylint = {version = "^3.2.6", python = "^3.10"}
-pytest = {version = "^8.3.2", python = "^3.10"}
-pytest-cov = {version = "^5.0.0", python = "^3.10"}
-toml = {version = "^0.10.1", python = "^3.10"}
-tox = "^4.1"
-types-toml = {version = "^0.10.1", python = "^3.10"}
-
-[tool.isort]
-profile = "black"
-force_single_line = "true"
-lines_after_imports = 2
+bandit = "^1.6.2"
+black = "^22.3.0"
+blacken-docs = "^1.8.0"
+ipython = {version = "^8.10.1", python = "^3.8"}
+mdformat = "^0.7"
+mdformat-gfm = "^0.3"
+mypy = "^0.930"
+pre-commit = "^2.7.1"
+pre-commit-hooks = "^3.3.0"
+pylint = "^2.13.0"
+pytest = "^6.0.2"
+pytest-cov = "^2.10.1"
+reorder-python-imports = "^2.3.5"
+safety = "^2.2.0"
+toml = "^0.10.1"
+tox = "^4"
+types-toml = "^0.10.1"
 
 [build-system]
 requires = ["poetry-core>=1.1.0"]

tests/test_installer.py

@@ -7,7 +7,6 @@ import tox.tox_env.python.virtual_env.runner
 from poetry.factory import Factory
 
 import tox_poetry_installer.hooks._tox_on_install_helpers
-
 from .fixtures import mock_poetry_factory
 from .fixtures import mock_venv
 

tests/test_metadata.py

@@ -3,7 +3,6 @@
 The next best thing to having one source of truth is having a way to ensure all of your
 sources of truth agree with each other.
 """
-
 from pathlib import Path
 
 import toml

tests/test_transients.py

@@ -4,10 +4,9 @@ import poetry.utils.env
 import pytest
 
 import tox_poetry_installer.hooks._tox_on_install_helpers
-from tox_poetry_installer import exceptions
-
 from .fixtures import mock_poetry_factory
 from .fixtures import mock_venv
+from tox_poetry_installer import exceptions
 
 
 def test_allow_missing():

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py3{8,9,10,11,12} static, static-tests, security
+envlist = py37, py38, py39, py310, py311, static, static-tests, security
 skip_missing_interpreters = true
 
 [testenv]
@@ -24,10 +24,10 @@ ignore_errors = true
 locked_deps =
     black
     blacken-docs
-    isort
     mdformat
     mdformat-gfm
     mypy
+    reorder-python-imports
     pre-commit
     pre-commit-hooks
     pylint
@@ -50,7 +50,6 @@ locked_deps =
     pylint
     pytest
     mypy
-    toml
     types-toml
 commands =
     pylint {toxinidir}/tests/ \
@@ -77,3 +76,14 @@ commands =
       --recursive \
       --quiet \
       --skip B101
+    poetry export \
+      --format requirements.txt \
+      --output {envtmpdir}/requirements.txt \
+      --without-hashes \
+      --with dev \
+      --extras poetry
+    safety check \
+      --file {envtmpdir}/requirements.txt \
+      --output text \
+      # https://github.com/pytest-dev/py/issues/287
+      --ignore 51457

tox_poetry_installer/_poetry.py

@@ -21,7 +21,6 @@ at the module scope it is imported into function scope wherever Poetry component
 moves import errors from load time to runtime which allows the plugin to be skipped if Poetry isn't
 installed and/or a more helpful error be raised within the Tox framework.
 """
-
 import sys
 
 from tox_poetry_installer import exceptions

tox_poetry_installer/constants.py

@@ -5,7 +5,6 @@ in this module.
 
 All constants should be type hinted.
 """
-
 from typing import Tuple
 
 from tox_poetry_installer import __about__

tox_poetry_installer/hooks/_tox_on_install_helpers.py

@@ -1,5 +1,4 @@
 """Helper functions for the :func:`tox_on_install` hook"""
-
 import collections
 import concurrent.futures
 import contextlib
@@ -21,7 +20,6 @@ from tox_poetry_installer import constants
 from tox_poetry_installer import exceptions
 from tox_poetry_installer import logger
 
-
 if typing.TYPE_CHECKING:
     from tox_poetry_installer import _poetry
 

tox_poetry_installer/hooks/tox_add_env_config.py

@@ -1,5 +1,4 @@
 """Add required env configuration options to the tox INI file"""
-
 from typing import List
 
 from tox.config.sets import EnvConfigSet

tox_poetry_installer/hooks/tox_add_option.py

@@ -1,5 +1,4 @@
 """Add additional command line arguments to tox to configure plugin behavior"""
-
 from tox.config.cli.parser import ToxParser
 from tox.plugin import impl
 

tox_poetry_installer/hooks/tox_on_install.py

@@ -4,7 +4,6 @@ Loads the local Poetry environment and the corresponding lockfile then pulls the
 specified by the Tox environment. Finally these dependencies are installed into the Tox
 environment using the Poetry ``PipInstaller`` backend.
 """
-
 from itertools import chain
 
 from tox.plugin import impl

tox_poetry_installer/logger.py

@@ -4,7 +4,6 @@ Calling ``tox.reporter.something()`` and having to format a string with the pref
 gets really old fast, but more importantly it also makes the flow of the main code
 more difficult to follow because of the added complexity.
 """
-
 import logging
 
 from tox_poetry_installer import constants